Bug Fix - Mark all messages as read does not work well

element-hq/element-ios#1425
matrix-org · Oct 19, 2017 · c2b0170 · c2b0170
1 parent 124639d
commit c2b0170
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/MatrixSDK/Data/MXRoom.m b/MatrixSDK/Data/MXRoom.m
@@ -2001,7 +2001,9 @@ - (void)markAllAsRead
     NSString *readMarkerEventId = nil;
     MXReceiptData *updatedReceiptData = nil;
 
-    NSString *lastMessageEventId = self.summary.lastMessageEvent.eventId;
+    // Retrieve the most recent event of the room.
+    MXEvent *lastEvent = [mxSession.store messagesEnumeratorForRoom:self.roomId].nextEvent;
+    NSString *lastMessageEventId = lastEvent.eventId;
 
     // Sanity check: Do not send read marker on event without id.
     if (!lastMessageEventId || [lastMessageEventId hasPrefix:kMXRoomInviteStateEventIdPrefix])
@@ -2048,6 +2050,9 @@ - (void)markAllAsRead
                         }
                     }
                 }
+
+                // Break the loop
+                break;
             }
         }
     }

diff --git a/MatrixSDK/Data/MXRoomSummary.h b/MatrixSDK/Data/MXRoomSummary.h
@@ -122,7 +122,7 @@ FOUNDATION_EXPORT NSString *const kMXRoomSummaryDidChangeNotification;
 #pragma mark - Data related to room state
 
 /**
- The avatar url of the room.
+ The Matrix content URI of the room avatar.
  */
 @property (nonatomic) NSString *avatar;