Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make [MXCrypto decryptEvent] asynchronous #205

Open
manuroe opened this issue Dec 14, 2016 · 1 comment
Open

Make [MXCrypto decryptEvent] asynchronous #205

manuroe opened this issue Dec 14, 2016 · 1 comment
Labels
enhancement

Comments

@manuroe
Copy link
Contributor

manuroe commented Dec 14, 2016

This feature needs to be done after event storage improvement refactoring.
@manuroe manuroe closed this as completed Dec 20, 2016
@manuroe manuroe reopened this Dec 21, 2016
@manuroe manuroe mentioned this issue Mar 8, 2017
Closed
@manuroe
Copy link
Contributor Author

manuroe commented Nov 8, 2017

Synchronousness is currently required for:

  • decrypting events in MXEventTimeline both for live and past messages
  • decrypting not sent messages
  • decrypting in some cases the last message for room summaries

Basically, the change will impact all methods using decryptEvent:

manuroe added a commit that referenced this issue Nov 8, 2017
@manuroe
Crypto: Do not block the main thread when retrying the decryption of …
83c9366 
…an event.

Retrying happens when we receive the key afterwards because of a late room key or because another user's device answers to our key share request.
In that case, as we are already in an asynchronously case, we do not need to come back to and block the main thread to decrypt the event as opposed to #205.
@manuroe manuroe mentioned this issue Nov 8, 2017
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@manuroe