Remove padding from base64 encoded iv value
#1059
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This uses the existing `MXBase64Tools` to trim the `=` padding from the base64 encoded string. The reinsertion of the padding prior to decoding was already implemented (line 224 in the same file). Closes: element-hq/element-ios#4172 Signed-off-by: Johannes Marbach <n0-0ne+github@mailbox.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This uses the existing
MXBase64Toolsto trim the=padding from the base64 encoded string. The reinsertion of the padding prior to decoding was already implemented (line 224 in the same file).Closes: element-hq/element-ios#4172
Signed-off-by: Johannes Marbach n0-0ne+github@mailbox.org
Pull Request Checklist