End of the removal of decryption on the main thread #1095
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
as it is not available in the decrypted JSON content
that does not pollute existing listeners on the live timeline There can be only one component that paginates message from a time else there is will be races.
Use MXSession.decryptEvents to get decrypted events.
…o decryptEvent:inTimeline:]
…ith the decryption queue. A single decryption takes 5ms on an iPhoneX. It was useless to synchronise this method with the busy decryption thread. There is no relationship. Note that this operation uses 0.5ms. It must not be called from the main thread. MatrixKit uses this method to build the timeline. It uses on a dedicated queue.
We must not call complete() before returning. It breaks pagination in MatrixKit that uses the returned MXHTTPOperation.
This method is called from the main thread. It should not use directly elf.crypto.deviceList that is managed by the cryptoQueue.
Co-authored-by: SBiOSoftWhare <SBiOSoftWhare@users.noreply.github.com>
Co-authored-by: SBiOSoftWhare <SBiOSoftWhare@users.noreply.github.com>
SBiOSoftWhare
approved these changes
May 20, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finish the work started in #1091.
Decryptions do not happen anymore on the main thread.
Synchronous decryption methods are marked as deprecated.
This makes the app much more reactive.