Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid calling SDK synchroniously in spaces classes #4999 #1260

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Avoid calling SDK synchroniously in spaces classes #4999 #1260

merged 2 commits into from
Oct 13, 2021

Conversation

gileluard
Copy link
Contributor

@gileluard gileluard commented Oct 13, 2021 •
edited
Loading

manuroe
manuroe approved these changes Oct 13, 2021
View reviewed changes
Copy link
Contributor

@manuroe manuroe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gileluard gileluard merged commit 571f456 into hotfix/1.6.4 Oct 13, 2021
@gileluard gileluard deleted the gil/4999_avoid_calling_SDK_synchroniously_in_spaces_classes branch October 13, 2021 12:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ismailgulek ismailgulek ismailgulek approved these changes

@manuroe manuroe manuroe approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@gileluard @ismailgulek @manuroe