Integrate MatrixSDKCrypto #1501
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team,
MaximeEvrard42 and
manuroe
and removed request for
a team
Anderas
commented
Jun 15, 2022
| @@ -22,12 +22,12 @@ Pod::Spec.new do |s| | |||
| s.requires_arc = true | |||
| s.swift_versions = ['5.1', '5.2'] | |||
|
|
|||
| s.ios.deployment_target = "10.0" | |||
| s.ios.deployment_target = "11.0" | |||
There was a problem hiding this comment.
Need to increase deployment target everywhere to 11, because 10 still supports 32bit architectures, whereas Rust has already dropped support for these architectures so MatrixCryptoSDK would be incompatible.
Anderas
commented
Jun 15, 2022
| private let machine: OlmMachine | ||
| public override init() { | ||
| do { | ||
| machine = try OlmMachine(userId: "", deviceId: "", path: "", passphrase: nil) |
There was a problem hiding this comment.
OlmMachine is a symbol defined in MatrixSDKCrypto pod
manuroe
reviewed
Jun 15, 2022
Is this in addition or instead of the existing |
In addition, you can have several changelog files in a PR. |
manuroe
approved these changes
Jun 16, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Builds on top of experimental
MXCryptoV2and integrates independently publishedMatrixSDKCryptoCocoaPod, published as offical CocoaPodTo avoid bloating up the size of production builds as well as making them safer, the new pod will only be loaded in DEBUG builds and is currently compiled only for iOS, as some of the internal libraries in Rust Crypto cannot be compiled for macos at the moment. This will be resolved in the future but does not have to be a blocker at this point.
Finally note that the instantiation of
OlmMachinein this PR means the integration of the pod works as expected.