Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(refactor) project settings update #1543

Merged
merged 4 commits into from
Aug 12, 2022

Conversation

mredig
Copy link
Contributor

@mredig mredig commented Aug 5, 2022

updated to match Xcode recommended settings. There were some target version bumps, so if you want me to revert those, just lemme know.

Signed-off-by: Michael Redig hybrids-07-baggage at icloud.com

Pull Request Checklist

@mredig mredig marked this pull request as ready for review August 5, 2022 23:51
@codecov-commenter
Copy link

codecov-commenter commented Aug 9, 2022

Codecov Report

Merging #1543 (f62d688) into develop (56a23ee) will decrease coverage by 0.00%.
The diff coverage is n/a.

@@             Coverage Diff             @@
##           develop    #1543      +/-   ##
===========================================
- Coverage    42.10%   42.10%   -0.01%     
===========================================
  Files          515      515              
  Lines        84113    84113              
  Branches     37064    37063       -1     
===========================================
- Hits         35418    35414       -4     
- Misses       47663    47668       +5     
+ Partials      1032     1031       -1     
Impacted Files Coverage Δ
...atrixSDKTests/MXThreadEventTimelineUnitTests.swift 58.77% <0.00%> (-13.75%) ⬇️
MatrixSDK/Threads/MXThread.swift 32.27% <0.00%> (-3.80%) ⬇️
...a/EventTimeline/Thread/MXThreadEventTimeline.swift 10.77% <0.00%> (-1.01%) ⬇️
MatrixSDK/Data/Store/MXFileStore/MXFileStore.m 61.92% <0.00%> (-0.32%) ⬇️
MatrixSDK/Data/MXRoomState.m 69.26% <0.00%> (ø)
MatrixSDK/MXRestClient.m 45.72% <0.00%> (+0.06%) ⬆️
MatrixSDK/MXSession.m 47.91% <0.00%> (+0.12%) ⬆️
MatrixSDK/Crypto/MXCrypto.m 50.99% <0.00%> (+0.19%) ⬆️
MatrixSDK/Data/MXRoom.m 35.11% <0.00%> (+0.26%) ⬆️
MatrixSDK/Utils/MXHTTPClient.m 51.61% <0.00%> (+0.50%) ⬆️
... and 3 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@pixlwave pixlwave left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @mredig, thanks for this PR. Looks fine to me, but yes please could you revert the deployment target back to iOS 11 for us 🙏.

@mredig
Copy link
Contributor Author

mredig commented Aug 10, 2022

targets reverted :)

@pixlwave pixlwave merged commit ca9a0ef into matrix-org:develop Aug 12, 2022
@pixlwave
Copy link
Contributor

Thanks @mredig

stefanceriu pushed a commit that referenced this pull request Aug 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants