Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow setting room alias regardless of join rule #1559

Merged
merged 1 commit into from
Aug 25, 2022

Conversation

aringenbach
Copy link
Contributor

This simply allows to set a room alias on room creation regardless of join rule.

@aringenbach aringenbach force-pushed the aringenbach/allow_room_alias_for_any_join_rule branch from 3d11bee to 775e41f Compare August 23, 2022 14:34
@aringenbach aringenbach requested review from a team and gileluard and removed request for a team August 23, 2022 14:46
Copy link
Contributor

@gileluard gileluard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@aringenbach aringenbach merged commit dd73158 into develop Aug 25, 2022
@aringenbach aringenbach deleted the aringenbach/allow_room_alias_for_any_join_rule branch August 25, 2022 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants