Enable group session cache by default #1575
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
gileluard
and removed request for
a team
Codecov ReportBase: 12.48% // Head: 12.49% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1575 +/- ##
========================================
Coverage 12.48% 12.49%
========================================
Files 521 521
Lines 85051 85002 -49
Branches 36217 36194 -23
========================================
- Hits 10622 10620 -2
+ Misses 74043 73996 -47
Partials 386 386
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After running a store / cache megolm decryption A/B test for a few weeks we gathered that cache decryption is aprox 10x faster and no new issues have been reported. As a result we can switch to cache variant exclusively, but leave the build flag in for a bit longer as a safety measure.