Disable codecov/patch. #1579
Merged
Disable codecov/patch. #1579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pixlwave
force-pushed
the
doug/codecov-patch
branch
from
5712d2b
to
8e77dc8
Compare
pixlwave
requested review from
a team and
paleksandrs
and removed request for
a team
Codecov ReportBase: 12.48% // Head: 12.48% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1579 +/- ##
========================================
Coverage 12.48% 12.48%
========================================
Files 521 521
Lines 84974 84974
Branches 36180 36180
========================================
+ Hits 10610 10612 +2
+ Misses 73977 73976 -1
+ Partials 387 386 -1
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
|
Hey Doug, it seems that there are some failing tests. I guess it is nothing to do with your change, but should we still be merging it? |
|
@paleksandrs Sadly these are flakey and appear to be failing on all the PRs, so not a concern for merging this PR. |
paleksandrs
approved these changes
Oct 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Same change as element-hq/element-ios#6757 but on the SDK.