Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Matrix client information on account data #1582

Merged
merged 3 commits into from
Sep 26, 2022

Conversation

ismailgulek
Copy link
Contributor

Fixes PSG-768 and PSG-770

@ismailgulek ismailgulek requested a review from a team September 26, 2022 12:52
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Sep 26, 2022

Codecov Report

Base: 12.48% // Head: 12.48% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (c6dd862) compared to base (14cb2f3).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1582      +/-   ##
===========================================
- Coverage    12.48%   12.48%   -0.01%     
===========================================
  Files          521      521              
  Lines        84974    84998      +24     
  Branches     36180    36189       +9     
===========================================
  Hits         10610    10610              
- Misses       73977    74001      +24     
  Partials       387      387              
Impacted Files Coverage Δ
MatrixSDK/MXRestClient.m 2.48% <ø> (ø)
MatrixSDK/MXSession.m 7.57% <0.00%> (-0.06%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@ismailgulek ismailgulek merged commit 9651cec into develop Sep 26, 2022
@ismailgulek ismailgulek deleted the ismail/client_information branch September 26, 2022 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants