Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate Mac-compatible MatrixSDKCrypto #1603

Merged
merged 3 commits into from
Oct 13, 2022
Merged

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 11, 2022

We don't really need to support Crypto V2 on the mac, but it does allow us to remove a bunch of annoying compiler flags and finally run unit tests on CI that runs against macos target

@Anderas Anderas requested review from a team and paleksandrs and removed request for a team October 11, 2022 09:19
@codecov
Copy link

codecov bot commented Oct 11, 2022

Codecov Report

Base: 13.66% // Head: 15.72% // Increases project coverage by +2.06% 🎉

Coverage data is based on head (06c67a2) compared to base (66df019).
Patch coverage: 5.00% of modified lines in pull request are covered.

Additional details and impacted files
@@                 Coverage Diff                  @@
##           andy/qr_refactor    #1603      +/-   ##
====================================================
+ Coverage             13.66%   15.72%   +2.06%     
====================================================
  Files                   543      572      +29     
  Lines                 86944    90664    +3720     
  Branches              36924    38283    +1359     
====================================================
+ Hits                  11880    14258    +2378     
- Misses                74620    75939    +1319     
- Partials                444      467      +23     
Impacted Files Coverage Δ
...xSDK/Crypto/CrossSigning/Data/MXCrossSigningInfo.m 31.37% <ø> (+31.37%) ⬆️
...rossSigning/Data/MXCryptoUserIdentityWrapper.swift 100.00% <ø> (ø)
...Crypto/CrossSigning/MXCrossSigningInfoSource.swift 100.00% <ø> (ø)
...trixSDK/Crypto/CrossSigning/MXCrossSigningV2.swift 27.11% <ø> (ø)
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
...rixSDK/Crypto/CryptoMachine/MXCryptoRequests.swift 29.22% <ø> (ø)
...chine/MXEventDecryptionResult+DecryptedEvent.swift 0.00% <ø> (ø)
...DK/Crypto/Devices/Data/MXCryptoDeviceWrapper.swift 100.00% <ø> (ø)
MatrixSDK/Crypto/Devices/Data/MXDeviceInfo.m 26.43% <ø> (+9.66%) ⬆️
MatrixSDK/Crypto/Devices/MXDeviceInfoSource.swift 100.00% <ø> (ø)
... and 70 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 1959be4 into andy/qr_refactor Oct 13, 2022
@Anderas Anderas deleted the andy/mac_crypto branch October 13, 2022 09:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants