Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unencrypted verification events in Crypto V2 #1605

Merged
merged 1 commit into from
Oct 13, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 13, 2022

The last few changes (for a while) in verification for Crypto V2:

  • process unencrypted verification events manually (they obviously cannot be handled automatically when calling decryptRoomEvent)
  • add support for SAS decimals
  • restore pending verification requests after app relaunch

@Anderas Anderas requested review from a team and stefanceriu and removed request for a team October 13, 2022 09:49
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm 👍

@codecov
Copy link

codecov bot commented Oct 13, 2022

Codecov Report

Base: 15.91% // Head: 15.93% // Increases project coverage by +0.01% 🎉

Coverage data is based on head (be50579) compared to base (d46bc7b).
Patch coverage: 36.66% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #1605      +/-   ##
===========================================
+ Coverage    15.91%   15.93%   +0.01%     
===========================================
  Files          575      575              
  Lines        91034    91085      +51     
  Branches     38394    38417      +23     
===========================================
+ Hits         14492    14511      +19     
- Misses       76075    76106      +31     
- Partials       467      468       +1     
Impacted Files Coverage Δ
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
...cation/Transactions/SAS/MXOutgoingSASTransaction.m 0.00% <ø> (ø)
...o/Verification/Transactions/SAS/MXSASTransaction.m 20.66% <0.00%> (-0.16%) ⬇️
...ypto/Verification/MXKeyVerificationManagerV2.swift 32.50% <8.33%> (-0.92%) ⬇️
...fication/Transactions/SAS/MXSASTransactionV2.swift 56.29% <50.00%> (+0.91%) ⬆️
...s/Crypto/CryptoMachine/MXCryptoProtocolStubs.swift 61.19% <50.00%> (-0.53%) ⬇️
...fication/Requests/MXKeyVerificationRequestV2.swift 97.39% <100.00%> (ø)
...on/Transactions/QRCode/MXQRCodeTransactionV2.swift 46.87% <100.00%> (ø)
...Transactions/SAS/MXSASTransactionV2UnitTests.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas merged commit 1689413 into develop Oct 13, 2022
@Anderas Anderas deleted the andy/complete_verification branch October 13, 2022 11:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants