Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set local trust with Crypto V2 and deprecate legacy verification method #1613

Merged
merged 1 commit into from
Oct 25, 2022

Conversation

Anderas
Copy link
Contributor

@Anderas Anderas commented Oct 19, 2022

A few final bits to implement CryptoV2:

  • set local trust (incl (un)blacklisting users)
  • remove deprecated and legacy verification method that does not begin with verification request (use requestVerificationWithDevice instead)
  • determine room encryption state
  • retry decryption of events after manually importing keys

@Anderas Anderas changed the title Set local trust with Crypto V2 Set local trust with Crypto V2 and deprecate legacy verification method Oct 19, 2022
@Anderas Anderas requested review from a team, Velin92 and manuroe and removed request for a team October 19, 2022 12:09
@codecov
Copy link

codecov bot commented Oct 19, 2022

Codecov Report

❗ No coverage uploaded for pull request base (develop@5960e8b). Click here to learn what that means.
Patch coverage: 14.00% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##             develop    #1613   +/-   ##
==========================================
  Coverage           ?   15.77%           
==========================================
  Files              ?      575           
  Lines              ?    90921           
  Branches           ?    38355           
==========================================
  Hits               ?    14347           
  Misses             ?    76107           
  Partials           ?      467           
Impacted Files Coverage Δ
...trixSDK/Crypto/CryptoMachine/MXCryptoMachine.swift 0.00% <0.00%> (ø)
MatrixSDK/Crypto/MXCryptoV2.swift 0.80% <0.00%> (ø)
...SDK/Crypto/Verification/MXKeyVerificationManager.m 0.00% <ø> (ø)
...s/Crypto/CryptoMachine/MXCryptoProtocolStubs.swift 54.10% <0.00%> (ø)
...fication/MXKeyVerificationManagerV2UnitTests.swift 89.28% <ø> (ø)
MatrixSDKTests/MXCryptoKeyVerificationTests.m 0.00% <ø> (ø)
...ypto/Verification/MXKeyVerificationManagerV2.swift 28.86% <19.23%> (ø)
...fication/Transactions/SAS/MXSASTransactionV2.swift 54.96% <100.00%> (ø)
...Transactions/SAS/MXSASTransactionV2UnitTests.swift 100.00% <100.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@Anderas Anderas requested review from a team and stefanceriu and removed request for Velin92, manuroe and a team October 24, 2022 07:39
Base automatically changed from andy/final_backups to develop October 24, 2022 11:37
Copy link
Contributor

@stefanceriu stefanceriu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from one small comment lgtm 👍

@Anderas Anderas merged commit c28fa51 into develop Oct 25, 2022
@Anderas Anderas deleted the andy/trust_devices branch October 25, 2022 13:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants