Curate MXCrypto protocol methods #1618
Conversation
Anderas
force-pushed
the
andy/crypto_methods
branch
from
557ea98
to
c6069f2
Compare
Anderas
requested review from
a team and
gileluard
and removed request for
a team
| @@ -314,6 +314,11 @@ - (void)signUserWithUserId:(NSString*)userId | |||
| }); | |||
| } | |||
|
|
|||
| - (MXCrossSigningInfo *)crossSigningKeysForUser:(NSString *)userId | |||
| { | |||
| return [self.crypto.store crossSigningKeysForUser:userId]; | |||
There was a problem hiding this comment.
Implementation merely moved here from MXCrypto
| /** | ||
| The secret storage on homeserver manager. | ||
| */ | ||
| @property (nonatomic, readonly) MXSecretStorage *secretStorage; |
There was a problem hiding this comment.
All of these (apart from deprecated decryptEvent and duplciate trustLevelSummary) are just moved to MXLegacyCrypto without change
| @@ -48,6 +48,7 @@ public actor MXTaskQueue { | |||
| assertionFailure("Failing to get value of the correct type should not be possible") | |||
| throw Error.valueUnavailable | |||
| } | |||
| previousTask = nil | |||
There was a problem hiding this comment.
Unrelated and untestable change that clears a Task after it has been completed. Without this change everything works as normal, but we keep a supended Task in memory unnecessarily
Anderas
force-pushed
the
andy/crypto_methods
branch
from
c6069f2
to
afa3d61
Compare
Codecov ReportBase: 25.71% // Head: 36.37% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1618 +/- ##
============================================
+ Coverage 25.71% 36.37% +10.65%
============================================
Files 577 577
Lines 90963 90876 -87
Branches 39486 39539 +53
============================================
+ Hits 23391 33056 +9665
+ Misses 66807 56838 -9969
- Partials 765 982 +217
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
A number of related changes to the
MXCryptoprotocol:MXCryptoprotocol by moving a number of methods and properties intoMXLegacyCrypto, because they are used only with the legacy implementation of the crypto module, and thus do not need to be implemented byMXCryptoV2trustLevelSummaryinto onedecryptEventmethodNote that in the future PR the remaining unimplemented methods in CryptoV2 will be dealt with