Fix backup performance with Crypto V2 #1641
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/backup_perf
branch
from
97e0fdf
to
cdc4f81
Compare
Anderas
force-pushed
the
andy/backup_perf
branch
from
cdc4f81
to
3cfc84d
Compare
Anderas
requested review from
a team and
Velin92
and removed request for
a team
Codecov ReportBase: 16.03% // Head: 36.15% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1641 +/- ##
============================================
+ Coverage 16.03% 36.15% +20.12%
============================================
Files 583 583
Lines 92561 92578 +17
Branches 39042 40248 +1206
============================================
+ Hits 14840 33474 +18634
+ Misses 77234 58099 -19135
- Partials 487 1005 +518
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Velin92
approved these changes
Nov 24, 2022
Yea our flaky integration tests 😞. Confirmed that failing tests pass locally |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The check to see whether we have any keys to backup relies on getting the actual count of total vs backed-up keys. For large accounts this rust method is very compute intensive and blocks the main thread. This has to be improved on the rust side, but for the time being we will return a cached count synchronously and then compute the actual count on a separate thread asynchronously. This will free up the main thread.
Additionally and unrelatedly I noticed that space graph computation during sync also blocks the main thread (once again for large accounts). This is due to an innocent looking
MXRoom.isDirectmethod that actually has O(n) performance. Instead of being a state property, it is a computed property that iterates through all direct rooms to determine if itself is direct or not. Changing the performance of this method is a rabbit hole I don't want to get into. Luckily the solution is quite simple, given thatMXSpaceServicecan use an existingMXSession.directRoomsmethod to get all of the ids at once, instead of doing essentially O(n^2) work (for every room, check every other direct room).