Calculate sync progress state #1643
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
requested review from
a team and
stefanceriu
and removed request for
a team
Anderas
force-pushed
the
andy/sync_progress
branch
from
b1cf32c
to
dade4df
Compare
Codecov ReportBase: 16.03% // Head: 25.34% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1643 +/- ##
===========================================
+ Coverage 16.03% 25.34% +9.31%
===========================================
Files 583 585 +2
Lines 92561 92686 +125
Branches 39042 40203 +1161
===========================================
+ Hits 14840 23493 +8653
+ Misses 77234 68413 -8821
- Partials 487 780 +293
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
MXSessionSyncProgresswhich tracks and calculates the state of the sync in order to determine whether we are waiting for the server response (and after how many attempts) or what is the overal percentage of data processed. For large accounts we may need to do 2-3 sync attempts with the server and data processing could take minutes, thus knowing what is the percentage completed can help users see how much longer they have to wait.The design of sync progress is such that individual phases may choose to calculate progress however they like (e.g. handling of sync response only looks at rooms, not groups), and this single number is then incorporated in the overal sync progress, which depends on the number of phases. The design also makes it easy to add new phases in the future with ease if new areas need to report their progress.
This feature is currently under a feature flag and disabled by default.
Additionally fix some warnings with nullability and
MatrixSDKCryptowarnings.