Notifications with Crypto V2 #1644
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/crypto_notifications
branch
from
5acf485
to
0c93456
Compare
Anderas
requested review from
a team and
ismailgulek
and removed request for
a team
Anderas
force-pushed
the
andy/crypto_notifications
branch
from
0c93456
to
3b7578c
Compare
Anderas
commented
Nov 23, 2022
|
|
||
| import Foundation | ||
|
|
||
| class MXLegacyBackgroundCrypto: MXBackgroundCrypto { |
There was a problem hiding this comment.
All code in this class is moved unchaged from MXBackgroundSyncService
Anderas
force-pushed
the
andy/crypto_notifications
branch
from
3b7578c
to
3c81cbc
Compare
Codecov ReportBase: 16.03% // Head: 16.01% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## develop #1644 +/- ##
===========================================
- Coverage 16.03% 16.01% -0.02%
===========================================
Files 583 585 +2
Lines 92561 92644 +83
Branches 39042 39072 +30
===========================================
Hits 14840 14840
- Misses 77234 77317 +83
Partials 487 487
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extract
OlmDeviceandMXBackgroundCryptoStoreout ofMXBackgroundSyncServiceand behind a newMXBackgroundCryptoprotocol. This protocol is similar toMXCryptobut with much smaller set of functionality, basically just the ability to recieve new room keys and decrypt events. All code moved out ofMXBackgroundSyncServiceintoMXLegacyBackgroundCryptois unchanged, apart from logs.Furthermore add
MXBackgroundCryptoV2which uses rust-basedCryptoMachineunder the hood and is also able to recieve keys and decrypt messages. One difference compared to the legacy crypto is that crypto v2 will only use one shared store between foreground and background processes meaning there is no need to synchronize these two stores.