Update to latest Crypto V2 Verification API #1654
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Anderas
force-pushed
the
andy/latest_crypto
branch
from
3028c5b
to
06216da
Compare
Anderas
requested review from
a team and
aringenbach
and removed request for
a team
Anderas
force-pushed
the
andy/latest_crypto
branch
from
06216da
to
f59b2c8
Compare
Anderas
force-pushed
the
andy/latest_crypto
branch
from
f59b2c8
to
b3894a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A number of changes in crypto verification API (only for Crypto V2) originating in
rust-sdk-crypto. Unfortunatelly this is quite a lot of changes and there is no easy way to break this up. In the future we should be deprecating API in upstream SDKs before removing them entirely, which will make upgrades easier. The changes include:Sas(but notQrCode) verification updates its state via a callback. This makes it easier to observe updates instead of needing to manuallyprocessUpdates.QrCodewill be updated in similar regard in the future but for now uses the old approachOlmMachineare now instead exposed onVerificationRequest(eg.startSasVerificationrust-sdk-cryptohave changed from structs to protocols, which broke a lot of stubs in unit tests. This PR fixes that wherever possible