macOS Compatibility #218
Merged
macOS Compatibility #218
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rly replace UIViews with NSViews
…the right tool for this job.
…deleted the macOS build target earlier.
manuroe
reviewed
Jan 16, 2017
There was a problem hiding this comment.
Awesome! Thanks a lot for this PR.
pod lib lint reports 2 warnings. Could you please fix them?
-> MatrixSDK (0.7.4)
- WARN | [OSX] xcodebuild: /Users/manu/tmp/matrix-ios-sdk/MatrixSDK/Data/Store/MXFileStore/MXFileStore.m:481:17: warning: unused variable 'startDate' [-Wunused-variable]
- WARN | [OSX] xcodebuild: /Users/manu/tmp/matrix-ios-sdk/MatrixSDK/Data/MXRoom.m:713:48: warning: null passed to a callee that requires a non-null argument [-Wnonnull]
|
That should do it. |
manuroe
approved these changes
Jan 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enables macOS compatibility via cocoapods. See #216
Note: The current version of OLMKit currently won't work with a macOS build target over cocoapods. I forked the OLMKit repository at https://github.com/aapierce0/OLMKit which updates the podspec to include a macOS deployment target. (I also replaced a
UIKitimport withFoundation) That should be the only change that's needed for macOS compatibility.Signed-off-by: Avery Pierce aapierce0@gmail.com