Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Display the consent tool in case of M_CONSENT_NOT_GIVEN error #498

Merged
merged 5 commits into from
May 23, 2018

Conversation

SBiOSoftWhare
Copy link
Contributor

element-hq/element-ios#1871

Post a notification if user have not yet consent to GDPR

@SBiOSoftWhare SBiOSoftWhare changed the title Post a notification in case of M_CONSENT_NOT_GIVEN error Display the consent tool in case of M_CONSENT_NOT_GIVEN error May 23, 2018
@@ -62,6 +63,17 @@ -(id)initWithErrorCode:(NSString*)errcode error:(NSString*)error
return self;
}

- (id)initWithErrorCode:(NSString*)errcode error:(NSString*)error userInfo:(NSDictionary*)userInfo {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing \n

@@ -39,6 +39,24 @@
*/
NSString * const MXHTTPClientErrorResponseDataKey = @"com.matrixsdk.httpclient.error.response.data";

/**
Posted when the user did not consent to GDPR.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Usually, we do not comment symbols that already commented in .h

@SBiOSoftWhare SBiOSoftWhare merged commit 93e7264 into develop May 23, 2018
@SBiOSoftWhare SBiOSoftWhare deleted the riot_1871 branch May 23, 2018 15:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants