Replies: Implement sending #534
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tring localizations when send reply to a message in a room.
…ult localization strings used when send reply event to a message in a room.
…pted content when encrypting an event.
…clear content when decrypting an event.
…d content when encrypting an event. Fix send reply formatted body building when input formatted body is nil.
…ge. Add a better check for `m.relates_to` content field validity.
manuroe
approved these changes
Jul 24, 2018
MatrixSDK/Data/MXRoom.m
Outdated
| { | ||
| if (eventToReply.eventType != MXEventTypeRoomMessage) | ||
| { | ||
| return false; |
MatrixSDKTests/MXRoomTests.m
Outdated
| NSString *expectedSecondEventBody = [NSString stringWithFormat:expectedSecondEventBodyStringFormat, firstEventSender]; | ||
| NSString *expectedSecondEventFormattedBody = [NSString stringWithFormat:expectedSecondEventFormattedBodyStringFormat, permalinkToEvent, permalinkToUser, firstEventSender]; | ||
|
|
||
| XCTAssert([secondEventBody isEqualToString:expectedSecondEventBody]); |
There was a problem hiding this comment.
Use XCTAssertEqualObjects to compare strings. This is helpful to debug remotely.
manuroe
approved these changes
Jul 24, 2018
manuroe
pushed a commit
that referenced
this pull request
Jul 24, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement reply to an event with text message.
element-hq/element-ios#1911