Avoid creating two devices on registration #1305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Ignore poll requests after a UIA session has finished. Sometimes the app calls poll() even after the registration has succeeded which causes the API call to happen again which, in the case of registration, creates a phantom device. Fixes element-hq/element-web#13040
jryans
approved these changes
Apr 7, 2020
bwindels
approved these changes
Apr 7, 2020
| @@ -318,6 +320,8 @@ InteractiveAuth.prototype = { | |||
| try { | |||
| const result = await this._requestCallback(auth, background); | |||
| this._resolveFunc(result); | |||
| this._resolveFunc = null; | |||
There was a problem hiding this comment.
Should we do the same when calling _rejectFunc below on line 387?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ignore poll requests after a UIA session has finished. Sometimes
the app calls poll() even after the registration has succeeded
which causes the API call to happen again which, in the case of
registration, creates a phantom device.
Fixes element-hq/element-web#13040