-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use the correct request body for the /keys/query endpoint. #1307
Conversation
Not removing tests until it is certain that spec is correct and riot is wrong :D Sometimes the spec isn't updates fast enough |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, thanks for looking at this! I think it may be an error in the spec, but let's ask @uhoreg to double check.
People at ruma (and Timo who implements the new rust server) found this. I am only implementing their findings in riot/react-sdk/js-sdk as I have knowledge about riot stuff :) |
The spec and this PR are correct. It's an array of device IDs, or an empty array if the query is for all devices. Synapse just does a Once the unit tests are fixed, this should be fine to merge. |
According to https://matrix.org/docs/spec/client_server/r0.6.0#post-matrix-client-r0-keys-query
The request should contain:
instead of
which currently gets send.
Signed-off-by: Marcel Radziomtrnord1@gmail.com