Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use SAS emoji data from matrix-doc (mk II) #1442

Closed
wants to merge 2 commits into from

Conversation

turt2live
Copy link
Member

@turt2live turt2live commented Aug 18, 2020

Round 2 of #1440 - see that PR for details.


This change is marked as an internal change (Task), so will not be included in the changelog.

Fixes element-hq/element-web#14947

Much like element-web's Jitsi wrapper build steps, this downloads the emoji JSON at build time to ensure it gets reasonably updated. In the future, the spec might want to consider publishing a dedicated i18n package on npm for this, however this is fine for now. We download rather than copy/paste to ensure we always have an updated copy.
This is to fix upstream builds which fail to get the json file
@MadLittleMods MadLittleMods added the T-Task Refactoring, enabling or disabling functionality, other engineering tasks label Jun 2, 2022
@t3chguy
Copy link
Member

t3chguy commented Aug 18, 2023

This is incompatible with Rust Crypto, tackling a different way

@t3chguy t3chguy closed this Aug 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Refactoring, enabling or disabling functionality, other engineering tasks
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants