New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix glare related regressions #1851
Conversation
Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
If we can get localUsermediaStream gotUserMediaForAnswer() has alredy been called before Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Also I get the general principle but unsure specifically why this would have caused glare to break - would have been good to explain this in the PR description. I spent a while staring at the changes trying to work out what was related to glare, before realising when I looked at the individual commits.
Signed-off-by: 艩imon Brandner <simon.bra.ag@gmail.com>
Sorry, about that, I was a bit tired of this when making the PR, so I somehow didn't do that... The problem on the js-sdk side was that it tried to add a track to an The other changes were the things that I discovered on the way which confused me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah - makes sense, thanks
Fixes element-hq/element-web#18538
Requires matrix-org/matrix-react-sdk#6614
Type: defect
(will make a PR to release after approval)
Here's what your changelog entry will look like:
馃悰 Bug Fixes