Palid/fix/dont persist log level #1880
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Palid
force-pushed
the
palid/fix/dont-persist-log-level
branch
from
d0a600b
to
e71519c
Compare
Palid
pushed a commit
to element-hq/element-web
that referenced
this pull request
Sep 2, 2021
This commit gets rid of log-level data in localStorage which in some extreme cases could fill up the entire localStorage making the app unusable Followup to matrix-org/matrix-js-sdk#1880
Palid
added
the
T-Task
dbkr
approved these changes
Sep 2, 2021
Palid
pushed a commit
to element-hq/element-web
that referenced
this pull request
Sep 16, 2021
This commit gets rid of log-level data in localStorage which in some extreme cases could fill up the entire localStorage making the app unusable Followup to matrix-org/matrix-js-sdk#1880
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As we started persisting loglevels types in
localStorageit seems that we may have accidentally broken some user's applications permanently. This pull request gets rid of the loglevels persistence and tries to fix the issue.This change is marked as an internal change (Task), so will not be included in the changelog.