Improve thread partitioning for 2nd degree relations #2165
Conversation
|
@gsouquet I see that you are marking a lot of bugs fixed with this change. Did you get a chance to test all those cases? I have been testing only the responses-to-the-thread-root part. |
I did test all of them, and the partitioning was the root of all those issues. |
| if (this.filter) { | ||
| return this.filter.filterRoomTimeline(pendingEvents); | ||
| } else { |
There was a problem hiding this comment.
@germain-gg I'm trying to understand this change. I note it changed the behaviour of this method so that it no longer applies the TimelineSet's filter (despite what the documentation says), but really my question is: why doesn't the calling code just call room.getPendingEvents, if it actually wants all the pending events rather than going through the filter?
Fixes element-hq/element-web#20966
Fixes element-hq/element-web#20915
Fixes element-hq/element-web#20921
Fixes element-hq/element-web#20282
Fixes element-hq/element-web#20848
This PR currently has no changelog labels, so will not be included in changelogs.
Add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is plusX-Breaking-Changeif it's a breaking change.