Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw error if both browser-index and (node) index are loaded #2211

Merged
merged 2 commits into from
Mar 1, 2022

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Mar 1, 2022

This reverts commit 7fa01ff also as the fix is no longer necessary

image


This change is marked as an internal change (Task), so will not be included in the changelog.

@t3chguy t3chguy added the T-Task Tasks for the team like planning label Mar 1, 2022
@t3chguy t3chguy requested a review from a team as a code owner March 1, 2022 18:14
@codecov-commenter
Copy link

Codecov Report

Merging #2211 (c42c5a2) into develop (b782dee) will increase coverage by 0.01%.
The diff coverage is 25.00%.

@@             Coverage Diff             @@
##           develop    #2211      +/-   ##
===========================================
+ Coverage    57.70%   57.72%   +0.01%     
===========================================
  Files           90       90              
  Lines        16251    16249       -2     
  Branches      3737     3736       -1     
===========================================
+ Hits          9378     9379       +1     
+ Misses        6873     6870       -3     
Impacted Files Coverage Δ
src/browser-index.js 0.00% <0.00%> (ø)
src/client.ts 34.61% <ø> (+0.08%) ⬆️
src/index.ts 71.42% <50.00%> (-8.58%) ⬇️

@t3chguy t3chguy merged commit 9b429c1 into develop Mar 1, 2022
@t3chguy t3chguy deleted the t3chguy/fix/21253 branch March 1, 2022 20:42
@tiennguyen1293
Copy link

Hi, could you please help me how i can resolve to throw error?

Multiple matrix-js-sdk entrypoints detected!

image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Task Tasks for the team like planning
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants