Don't cancel SAS verifications if ready is received after start
#2250
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
it's completely valid to receive a `ready` event after having received a `start` event as messages may be received or decrypted in any order. partial (but possibly sufficient?) fix for element-hq/element-web#21488
Codecov Report
@@ Coverage Diff @@
## develop #2250 +/- ##
========================================
Coverage 58.11% 58.11%
========================================
Files 92 92
Lines 16427 16427
Branches 3782 3782
========================================
Hits 9546 9546
Misses 6881 6881
|
turt2live
approved these changes
Mar 22, 2022
There was a problem hiding this comment.
The spec wants us to validate the order, but it also doesn't say how to deal with the ordering or if order is guaranteed, so I suppose this is fine.
Given the risk of touching verification though, I'm tempted to merge this post-RC rather than now for absolute safety (though I also have zero hope of it being tested while on develop/staging anyways).
|
this is still a valid fix. the fact the spec asks us to validate ordering on something which has no ordering is a spec bug to be fixed. |
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Jun 7, 2022
* Convert `getLocalAliases` to a stable API call ([\matrix-org#2402](matrix-org#2402)). * Fix request, crypto, and bs58 imports ([\matrix-org#2414](matrix-org#2414)). Fixes matrix-org#2415. * Update relations after every decryption attempt ([\matrix-org#2387](matrix-org#2387)). Fixes element-hq/element-web#22258. Contributed by @weeman1337. * Fix degraded mode for the IDBStore and test it ([\matrix-org#2400](matrix-org#2400)). Fixes matrix-org/element-web-rageshakes#13170. * Don't cancel SAS verifications if `ready` is received after `start` ([\matrix-org#2250](matrix-org#2250)). * Prevent overlapping sync accumulator persists ([\matrix-org#2392](matrix-org#2392)). Fixes vector-im/element-web#21541. * Fix behaviour of isRelation with relation m.replace for state events ([\matrix-org#2389](matrix-org#2389)). Fixes element-hq/element-web#22280. * Fixes matrix-org#2384 ([\matrix-org#2385](matrix-org#2385)). Fixes undefined/matrix-js-sdk#2384. Contributed by @schmop. * Ensure rooms are recalculated on re-invites ([\matrix-org#2374](matrix-org#2374)). Fixes element-hq/element-web#22106.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
it's completely valid to receive a
readyevent after having received astartevent as messages may be received or decrypted in any order.partial (but possibly sufficient?) fix for element-hq/element-web#21488
Here's what your changelog entry will look like:
🐛 Bug Fixes
readyis received afterstart(#2250).