Mark room versions 7, 8, and 9 as safe #2318
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## develop #2318 +/- ##
========================================
Coverage 59.74% 59.74%
========================================
Files 91 91
Lines 16450 16450
Branches 3797 3797
========================================
Hits 9828 9828
Misses 6622 6622
|
turt2live
reviewed
Apr 25, 2022
t3chguy
reviewed
Apr 25, 2022
| @@ -55,8 +55,8 @@ import { TypedEventEmitter } from "./typed-event-emitter"; | |||
| // room versions which are considered okay for people to run without being asked | |||
| // to upgrade (ie: "stable"). Eventually, we should remove these when all homeservers | |||
| // return an m.room_versions capability. | |||
| const KNOWN_SAFE_ROOM_VERSION = '6'; | |||
| const SAFE_ROOM_VERSIONS = ['1', '2', '3', '4', '5', '6']; | |||
| const KNOWN_SAFE_ROOM_VERSION = '9'; | |||
There was a problem hiding this comment.
In practice, KNOWN_SAFE_ROOM_VERSION should be the same as the common default room version
Hmm @turt2live you sure about this given the spec is still saying default to 6
There was a problem hiding this comment.
Just missing spec at the moment: matrix-org/matrix-spec-proposals#3739
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Workaround for element-hq/element-web#20166 element-hq/element-web#11820
Signed-off-by: Aaron Raimist aaron@raim.ist
This PR currently has no changelog labels, so will not be included in changelogs.
A reviewer can add one of:
T-Deprecation,T-Enhancement,T-Defect,T-Taskto indicate what type of change this is, or addType: [enhancement/defect/task]to the description and I'll add them for you.