Prevent infinite loop in getPushRules #2470
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
During integration tests that start and stop the client quickly, getPushRules fails and doesn't exit cleanly. getPushRules fails with `Getting push rules failed M_MISSING_TOKEN: missing access token`, but shouldAbortSync only checks for `M_UNKNOWN_TOKEN` Tests: pulled down project locally and ran all tests.
github-actions
bot
added
the
Z-Community-PR
andybalaam
requested changes
Jun 28, 2022
That is a reasonable request. I will give it a shot when I get a minute. |
|
I don't currently have this issue. closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During integration tests that start and stop the client quickly, getPushRules fails and doesn't exit cleanly.
getPushRules fails with
Getting push rules failed M_MISSING_TOKEN: missing access token, but shouldAbortSync only checks forM_UNKNOWN_TOKENTests: pulled down project locally and ran all tests.
Signed-off-by: Austin Ellis austin@hntlabs.com
Here's what your changelog entry will look like:
🐛 Bug Fixes