Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Re-emit room state events on rooms #2607

Merged
merged 4 commits into from
Aug 22, 2022

Conversation

robintown
Copy link
Member

@robintown robintown commented Aug 19, 2022

This also fixes some potential memory leaks and abuse of removeAllListeners in sync.ts.

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass

Here's what your changelog entry will look like:

✨ Features

  • Re-emit room state events on rooms (#2607).

This also fixes some potential memory leaks and abuse of
removeAllListeners in sync.ts.
@robintown robintown added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Aug 19, 2022
@robintown robintown marked this pull request as ready for review August 19, 2022 20:13
@robintown robintown requested a review from a team as a code owner August 19, 2022 20:13
Copy link
Contributor

@SimonBrandner SimonBrandner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, otherwise

src/sync.ts Outdated Show resolved Hide resolved
@robintown robintown enabled auto-merge (squash) August 22, 2022 14:29
@robintown robintown merged commit b265d79 into matrix-org:develop Aug 22, 2022
@robintown robintown deleted the ec-video-rooms branch August 27, 2022 05:12
su-ex added a commit to SchildiChat/matrix-js-sdk that referenced this pull request Sep 1, 2022
* Re-emit room state events on rooms ([\matrix-org#2607](matrix-org#2607)).
* Add ability to override built in room name generator for an i18n'able one ([\matrix-org#2609](matrix-org#2609)).
* Add txn_id support to sliding sync ([\matrix-org#2567](matrix-org#2567)).
* Refactor Sync and fix `initialSyncLimit` ([\matrix-org#2587](matrix-org#2587)).
* Use deep equality comparisons when searching for outgoing key requests by target ([\matrix-org#2623](matrix-org#2623)). Contributed by @duxovni.
* Fix room membership race with PREPARED event ([\matrix-org#2613](matrix-org#2613)). Contributed by @jotto.
* fixed a sliding sync bug which could cause the `roomIndexToRoomId` map to be incorrect when a new room is added in the middle of the list or when an existing room is deleted from the middle of the list. ([\matrix-org#2610](matrix-org#2610)).
* Fix: Handle parsing of a beacon info event without asset ([\matrix-org#2591](matrix-org#2591)). Fixes element-hq/element-web#23078. Contributed by @kerryarchibald.
* Fix finding event read up to if stable private read receipts is missing ([\matrix-org#2585](matrix-org#2585)). Fixes element-hq/element-web#23027.
* fixed a sliding sync issue where history could be interpreted as live events. ([\matrix-org#2583](matrix-org#2583)).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants