Pre-allocate transceivers #3317
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
Signed-off-by: Šimon Brandner <simon.bra.ag@gmail.com>
EnricoSchw
reviewed
Apr 25, 2023
| for (const kind of ["audio", "video"]) { | ||
| this.peerConn!.addTransceiver(kind, { | ||
| direction: "recvonly", | ||
| }); |
There was a problem hiding this comment.
Hmm interesting. We creating every time a new transceiver, when we receive a screenshare. I was thinking thats this will done automatically.. I did not know that
There was a problem hiding this comment.
Not really. We do this in the case where we are going to be calling a user who is screen-sharing, so we need prepare receivers for the tracks
SimonBrandner
added
the
T-Enhancement
SimonBrandner
force-pushed
the
prealloc-trans
branch
from
1599fc1
to
c234787
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-call#1011
Here's what your changelog entry will look like:
✨ Features