Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

In chat export, make sender name differentiable using < > vector-im/e… #3345

Closed
wants to merge 1 commit into from
Closed

Conversation

rameshsinghppc
Copy link

@rameshsinghppc rameshsinghppc commented May 6, 2023

Fixes element-hq/element-web#23837

Signed-off-by: Ramesh Singh @rameshsinghppc

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

This PR currently has none of the required changelog labels.

A reviewer can add one of: T-Deprecation, T-Enhancement, T-Defect, T-Task to indicate what type of change this is, or add Type: [enhancement/defect/task] to the description and I'll add them for you.

@rameshsinghppc rameshsinghppc requested a review from a team as a code owner May 6, 2023 20:34
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label May 6, 2023
@rameshsinghppc
Copy link
Author

This PR is associated with the other PR (matrix-org/matrix-react-sdk#10748 (comment))

@justjanne
Copy link
Contributor

This PR is not a good solution for your issue, please see my comment on your other PR for a better suggestion of how to approach this.

@justjanne justjanne closed this May 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
2 participants