Add CryptoApi.getCrossSigningKeyId
#3360
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
richvdh
force-pushed
the
rav/element-r/08_stub_out_cross_signing_id
branch
from
0b76f7a
to
14a61e4
Compare
…tub_out_cross_signing_id
|
I'd like to request an exemption to the quality gate, because it's legacy code we want to throw away |
t3chguy
reviewed
May 12, 2023
richvdh
commented
May 15, 2023
richvdh
commented
May 15, 2023
t3chguy
reviewed
May 15, 2023
src/crypto-api.ts
Outdated
Comment on lines
150
to
151
| * @param type - The type of key to get the ID of. One of | ||
| * "master", "self_signing", or "user_signing". Defaults to "master". |
There was a problem hiding this comment.
This is misleading, as typescript won't let you specify these string values unless it is a const string enum, not a normal string enum.
t3chguy
approved these changes
May 15, 2023
richvdh
added a commit
that referenced
this pull request
May 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Another crypto function to stub out to get the Cypress tests running
This change is marked as an internal change (Task), so will not be included in the changelog.