Update MSC3912 implementation to use with_rel_type instead of with_relations
#3420
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
3 tasks
richvdh
changed the title
|
@weeman1337 a gentle request to try to make your PR subjects meaningful, and not to mark them as T-Task where there are functional changes :) |
richvdh
requested changes
May 31, 2023
richvdh
approved these changes
Jun 1, 2023
Comment on lines
+343
to
+345
| unstableFeatures = { | ||
| "org.matrix.msc3440.stable": true, | ||
| }; |
There was a problem hiding this comment.
Suggested change
| unstableFeatures = { | |
| "org.matrix.msc3440.stable": true, | |
| }; | |
| unstableFeatures["org.matrix.msc3440.stable"] = true; |
(though I'm not sure why it is being moved at all)
There was a problem hiding this comment.
This sets unstableFeatures to a defined state before each test. Another test sets an additional property on it:
matrix-js-sdk/spec/unit/matrix-client.spec.ts
Line 1400 in deb9089
There was a problem hiding this comment.
→ will add a comment
weeman1337
changed the title
with_rel_type instead of with_relations
su-ex
added a commit
to SchildiChat/matrix-js-sdk
that referenced
this pull request
Feb 22, 2024
* Introduce a new `Crypto.Verifier` interface, and deprecate direct access to `VerificationBase`, `SAS` and `ReciprocateQRCode` ([\matrix-org#3414](matrix-org#3414)). * Add `rust-crypto#isCrossSigningReady` implementation ([\matrix-org#3462](matrix-org#3462)). Contributed by @florianduros. * OIDC: Validate `m.authentication` configuration ([\matrix-org#3419](matrix-org#3419)). Contributed by @kerryarchibald. * ElementR: Add `CryptoApi.getCrossSigningStatus` ([\matrix-org#3452](matrix-org#3452)). Contributed by @florianduros. * Extend stats summary with call device and user count based on room state ([\matrix-org#3424](matrix-org#3424)). Contributed by @toger5. * Update MSC3912 implementation to use `with_rel_type` instead of `with_relations` ([\matrix-org#3420](matrix-org#3420)). * Export thread-related types from SDK ([\matrix-org#3447](matrix-org#3447)). Contributed by @stas-demydiuk. * Use correct /v3 prefix for /refresh ([\matrix-org#3016](matrix-org#3016)). Contributed by @davidisaaclee. * Fix thread list being ordered based on all updates ([\matrix-org#3458](matrix-org#3458)). Fixes element-hq/element-web#25522. * Fix: handle `baseUrl` with trailing slash in `fetch.getUrl` ([\matrix-org#3455](matrix-org#3455)). Fixes element-hq/element-web#25526. Contributed by @kerryarchibald. * use cli.canSupport to determine intentional mentions support ([\matrix-org#3445](matrix-org#3445)). Fixes element-hq/element-web#25497. Contributed by @kerryarchibald. * Make sliding sync linearize processing of sync requests ([\matrix-org#3442](matrix-org#3442)). * Fix edge cases around 2nd order relations and threads ([\matrix-org#3437](matrix-org#3437)).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adapts the implementation to the latest version of MSC3912
with_relations→with_rel_typeswith_rel_typesis now always a list of strings incl.*with_relationsand mark it as deprecated. It should be removed once the MSC becomes stable.Part of element-hq/element-web#25471
Checklist
Here's what your changelog entry will look like:
✨ Features
with_rel_typeinstead ofwith_relations(#3420).