Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Element-R: support for displaying QR codes during verification #3588

Merged
merged 6 commits into from Jul 13, 2023
Merged

Element-R: support for displaying QR codes during verification #3588

merged 6 commits into from Jul 13, 2023

Conversation

richvdh
Copy link
Member

@richvdh richvdh commented Jul 11, 2023 •
edited by github-actions bot

Closes https://github.com/vector-im/crypto-internal/issues/124

Here's what your changelog entry will look like:

✨ Features

  • Element-R: support for displaying QR codes during verification (#3588). Fixes vector-im/crypto-internal#124.

@richvdh richvdh added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jul 11, 2023
Base automatically changed from rav/39bis_bump_rust_sdk to develop July 11, 2023 17:53
@richvdh richvdh force-pushed the rav/element-r/39_show_qr_code branch from 8d3f558 to 651ba75 Compare July 11, 2023 20:05
@richvdh richvdh marked this pull request as ready for review July 11, 2023 20:09
@richvdh richvdh requested a review from a team as a code owner July 11, 2023 20:09
@richvdh richvdh mentioned this pull request Jul 11, 2023
Merged
t3chguy
t3chguy approved these changes Jul 12, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane otherwise

src/rust-crypto/verification.ts Show resolved Hide resolved
src/rust-crypto/verification.ts Outdated Show resolved Hide resolved
@richvdh richvdh added this pull request to the merge queue Jul 13, 2023
Merged via the queue into develop with commit d92936f Jul 13, 2023
23 of 24 checks passed
@richvdh richvdh deleted the rav/element-r/39_show_qr_code branch July 13, 2023 11:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@richvdh @t3chguy