Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix how Room::eventShouldLiveIn handles replies to unknown parents #3615

Merged
merged 2 commits into from Jul 24, 2023
Merged

Fix how Room::eventShouldLiveIn handles replies to unknown parents #3615

merged 2 commits into from Jul 24, 2023

Conversation

t3chguy
Copy link
Member

@t3chguy t3chguy commented Jul 21, 2023 •
edited by github-actions bot

This caused missing messages especially when building permalink timelines (/context API)

Fixes element-hq/element-web#22603

Here's what your changelog entry will look like:

馃悰 Bug Fixes

@t3chguy t3chguy added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jul 21, 2023
@t3chguy t3chguy requested a review from a team as a code owner July 21, 2023 13:30
kerryarchibald
kerryarchibald approved these changes Jul 24, 2023
View reviewed changes
Copy link
Contributor

@kerryarchibald kerryarchibald left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@t3chguy t3chguy added this pull request to the merge queue Jul 24, 2023
@t3chguy t3chguy mentioned this pull request Jul 24, 2023
Closed
Merged via the queue into develop with commit 6b018b6 Jul 24, 2023
26 checks passed
@t3chguy t3chguy deleted the t3chguy/missing-messages branch July 24, 2023 07:51
@Johennes Johennes mentioned this pull request Jul 24, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kerryarchibald kerryarchibald kerryarchibald approved these changes

@germain-gg germain-gg Awaiting requested review from germain-gg germain-gg is a code owner automatically assigned from matrix-org/element-web-reviewers

@florianduros florianduros Awaiting requested review from florianduros florianduros is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing parts in the timeline
2 participants
@t3chguy @kerryarchibald