Add E2EE for embedded mode of Element Call #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
and also move some code to a more sensible place in the file
Then we can initialise from the state once it's completed.
3 tasks
& add log line
robintown
reviewed
Oct 30, 2023
Comment on lines
+101
to
+111
| private onTimeline = (event: MatrixEvent): void => { | ||
| if (event.getType() !== EventType.CallEncryptionKeysPrefix) return; | ||
|
|
||
| const room = this.client.getRoom(event.getRoomId()); | ||
| if (!room) { | ||
| logger.error(`Got room state event for unknown room ${event.getRoomId()}!`); | ||
| return; | ||
| } | ||
|
|
||
| this.getRoomSession(room).onCallEncryption(event); | ||
| }; |
There was a problem hiding this comment.
Non-blocking, but I'm not convinced that this callback belongs in the session manager class. I think it makes most sense if the session manager is only responsible for creating, ending, and storing sessions, so this feels better suited for the session class itself.
There was a problem hiding this comment.
Yeah, I think I would agree: I guess it was sticking to the pattern of all the events going into the manager and being dispatched from there.
robintown
approved these changes
Oct 31, 2023
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based on #3663
For element-hq/element-call#1350
Here's what your changelog entry will look like:
✨ Features