Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sync knock rooms #3703

Merged
merged 5 commits into from Sep 6, 2023
Merged

Sync knock rooms #3703

merged 5 commits into from Sep 6, 2023

Conversation

maheichyk
Copy link
Contributor

@maheichyk maheichyk commented Sep 6, 2023 •
edited

We @nordeck are currently implementing the knock rooms behind the feature flag feature_ask_to_join (introduced in matrix-org/matrix-react-sdk#11182).

This PR reads knock information from the /sync endpoint.

Epic: element-hq/element-web#18655

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Type: enhancement

Here's what your changelog entry will look like:

✨ Features

Sync knock rooms
12ca6bb 
Signed-off-by: Mikhail Aheichyk <mikhail.aheichyk@nordeck.net>
@github-actions github-actions bot added Z-Community-PR Issue is solved by a community member's PR T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements labels Sep 6, 2023
@maheichyk maheichyk marked this pull request as ready for review September 6, 2023 08:17
@maheichyk maheichyk requested a review from a team as a code owner September 6, 2023 08:17
t3chguy
t3chguy approved these changes Sep 6, 2023
View reviewed changes
Copy link
Member

@t3chguy t3chguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks sane, thanks

@t3chguy t3chguy added this pull request to the merge queue Sep 6, 2023
Merged via the queue into matrix-org:develop with commit 6c307d4 Sep 6, 2023
18 checks passed
@maheichyk maheichyk deleted the knock_list branch September 6, 2023 20:07
@charlynguyen charlynguyen mentioned this pull request Sep 9, 2023
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t3chguy t3chguy t3chguy approved these changes

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@maheichyk @t3chguy