Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ElementR: Check key backup when user identity changes #3760

Merged
merged 3 commits into from Oct 3, 2023
Merged

ElementR: Check key backup when user identity changes #3760

merged 3 commits into from Oct 3, 2023

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Sep 29, 2023 •
edited

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

Fixes element-hq/element-web#26244
Cypress tests matrix-org/matrix-react-sdk#11686

Here's what your changelog entry will look like:

馃悰 Bug Fixes

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Sep 29, 2023
@florianduros florianduros force-pushed the florianduros/elementR/connect-keybackup branch from e0defa5 to e3396d7 Compare September 29, 2023 15:13
@florianduros florianduros mentioned this pull request Sep 29, 2023
Merged
3 tasks
@florianduros florianduros changed the title ElementR: Check key backup when user's identity change ElementR: Check key backup when user identity changes Sep 29, 2023
@florianduros florianduros force-pushed the florianduros/elementR/connect-keybackup branch from c2209e5 to 4dd1ace Compare October 2, 2023 14:48
@florianduros florianduros marked this pull request as ready for review October 2, 2023 16:05
@florianduros florianduros requested a review from a team as a code owner October 2, 2023 16:05
@florianduros florianduros requested review from andybalaam, dbkr and richvdh and removed request for andybalaam and dbkr October 2, 2023 16:05
richvdh
richvdh approved these changes Oct 2, 2023
View reviewed changes
Copy link
Member

@richvdh richvdh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm otherwise

src/rust-crypto/rust-crypto.ts Outdated Show resolved Hide resolved
@florianduros florianduros added this pull request to the merge queue Oct 3, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Oct 3, 2023
@florianduros florianduros added this pull request to the merge queue Oct 3, 2023
@richvdh richvdh removed this pull request from the merge queue due to a manual request Oct 3, 2023
@richvdh richvdh merged commit 2e42764 into develop Oct 3, 2023
23 checks passed
@richvdh richvdh deleted the florianduros/elementR/connect-keybackup branch October 3, 2023 12:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richvdh richvdh richvdh approved these changes

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ElementR: Device is not connected to Key Backup after verification
2 participants
@florianduros @richvdh