Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix reemitter not being correctly wired on user objects created in storage classes #3796

Merged
merged 10 commits into from Oct 27, 2023
Merged

Fix reemitter not being correctly wired on user objects created in storage classes #3796

merged 10 commits into from Oct 27, 2023

Conversation

MidhunSureshR
Copy link
Contributor

@MidhunSureshR MidhunSureshR commented Oct 12, 2023 •
edited by github-actions bot

Storage classes - memory.ts and indexeddb.ts both create user objects without setting it up to emit events on matrix client.
This is sometimes preventing the memberlist from updating on incoming presence events because this listener never runs.

Here's what your changelog entry will look like:

馃悰 Bug Fixes

  • Fix reemitter not being correctly wired on user objects created in storage classes (#3796). Contributed by @MidhunSureshR.

@MidhunSureshR MidhunSureshR added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Oct 12, 2023
@MidhunSureshR MidhunSureshR mentioned this pull request Oct 17, 2023
Open
MidhunSureshR
MidhunSureshR commented Oct 17, 2023
View reviewed changes
src/store/index.ts
* Set the user creator which is used for creating User objects
* @param creator - A callback that accepts an user-id and returns an User object
*/
setUserCreator(creator: UserCreator): void;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Temporary solution until we fix element-hq/element-web#26383

MidhunSureshR
MidhunSureshR commented Oct 17, 2023
View reviewed changes
Copy link
Contributor Author

@MidhunSureshR MidhunSureshR left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

.

@MidhunSureshR MidhunSureshR marked this pull request as ready for review October 17, 2023 12:58
@MidhunSureshR MidhunSureshR requested a review from a team as a code owner October 17, 2023 12:58
germain-gg
germain-gg suggested changes Oct 23, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for opening this up!
A few things I believe should be updated

src/models/user.ts Outdated Show resolved Hide resolved
src/models/user.ts Outdated Show resolved Hide resolved
germain-gg
germain-gg approved these changes Oct 27, 2023
View reviewed changes
Copy link
Contributor

@germain-gg germain-gg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, LGTM

@MidhunSureshR MidhunSureshR added this pull request to the merge queue Oct 27, 2023
Merged via the queue into develop with commit 88d066a Oct 27, 2023
18 checks passed
@MidhunSureshR MidhunSureshR deleted the midhun/fix-user-presence branch October 27, 2023 07:38
@t3chguy t3chguy mentioned this pull request Nov 7, 2023
Closed
@MidhunSureshR MidhunSureshR mentioned this pull request Nov 9, 2023
Merged
@WebFreak001 WebFreak001 mentioned this pull request Jan 5, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@germain-gg germain-gg germain-gg approved these changes

@t3chguy t3chguy Awaiting requested review from t3chguy t3chguy is a code owner automatically assigned from matrix-org/element-web-reviewers

@kerryarchibald kerryarchibald Awaiting requested review from kerryarchibald kerryarchibald is a code owner automatically assigned from matrix-org/element-web-reviewers

Assignees
No one assigned
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@MidhunSureshR @germain-gg