Explicitly free some Rust-side objects #3911
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
richvdh
added
the
T-Task
t3chguy
reviewed
Nov 28, 2023
Suggestions welcome! |
|
I know almost nothing about Rust, and absolutely nothing about incorporating Rust in Javascript. Equally though if switching to rust crypto means brittle as hell code I think I'm no longer in favour |
with the greatest respect, I feel like "should we adopt the Rust cryptography library in Element Web" is a discussion that is out of the scope of this PR. |
|
No arguing that |
t3chguy
approved these changes
Nov 28, 2023
t3chguy
added
T-Defect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Finalization in Javascript is not guaranteed - sometimes the FinalizationRegistry just forgets to call the finalizers on some objects. This is problematic because it means we leak references on the Rust side, which (as well as causing memory leaks) ultimately leads to us holding open the indexeddb, which then means we can't successfully log in/out.
This isn't meant to be a comprehensive fix, but it does add explicit
freecalls in a number of places which seem particularly prone to leaking, and empirically it was enough for me to get a Cypress test which logs out and back in working again.Here's what your changelog entry will look like:
馃悰 Bug Fixes