Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backport staging] Broaden spec version support #4016

Merged
merged 1 commit into from
Jan 18, 2024

Conversation

RiotRobot
Copy link
Contributor

@RiotRobot RiotRobot commented Jan 18, 2024

Backport c885542 from #4014.


Here's what your changelog entry will look like:

✨ Features

  • [Backport staging] Broaden spec version support (#4016). Contributed by @RiotRobot.

This commit does two things:

 * It puts the "minimum supported matrix version" from v1.5 back down to
   v1.1. In other words, it is a partial revert of
   #3970. (Partial, because we
   don't need to update the tests.)

   We're doing this largely because
   #3970 was introduced without
   a suitable announcement and deprecation policy. We haven't yet decided if
   the js-sdk's spec support policy needs to change, or if we will re-introduce
   this change in future in a more graceful manner.

 * It increases the "maximum supported matrix version" from v1.5 up to
   v1.9. Previously, the two concepts were tied together, but as discussed at
   length in
   #3915 (comment),
   this is incorrect.

   Unfortunately, we have no real way of testing whether it is true that the
   js-sdk actually works with a server which supports *only* v1.9, but as per
   the comment above, we can't do much about that.

Fixes #3915.

(cherry picked from commit c885542)
@RiotRobot RiotRobot requested a review from a team as a code owner January 18, 2024 16:57
@RiotRobot RiotRobot requested a review from dbkr January 18, 2024 16:57
@RiotRobot RiotRobot added the T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements label Jan 18, 2024
@RiotRobot RiotRobot added the X-Release-Blocker This affects the current release cycle and must be solved for a release to happen label Jan 18, 2024
@github-actions github-actions bot added the Z-Community-PR Issue is solved by a community member's PR label Jan 18, 2024
@t3chguy t3chguy merged commit abd920f into staging Jan 18, 2024
27 checks passed
@t3chguy t3chguy deleted the backport-4014-to-staging branch January 18, 2024 17:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Enhancement New features, changes in functionality, performance boosts, user-facing improvements X-Release-Blocker This affects the current release cycle and must be solved for a release to happen Z-Community-PR Issue is solved by a community member's PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants