Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make timeline a getter #4022

Merged
merged 4 commits into from Jan 26, 2024
Merged

Conversation

florianduros
Copy link
Contributor

@florianduros florianduros commented Jan 22, 2024

Checklist

  • Tests written for new code (and old code if feasible)
  • Linter and other CI checks pass
  • Sign-off given on the changes (see CONTRIBUTING.md)

When looking for stuck unreads, we noticed sometimes that timeline and this.getLiveTimeline().getEvents() are different.

timeline is a copy of this.getLiveTimeline().getEvents() which is manually updated. To avoid missing copy, timeline becomes a getter of this.getLiveTimeline().getEvents().

Also make timeline deprecated.

After some days of testing it, it seems to get rid of the remaining stuck unreads and make disappear some of the zombie notifications.

Closes element-hq/element-web#26878
Part of element-hq/element-web#24392

Notes: Fix cases of stuck unreads and zombie notifications (comes back after a refresh)


Here's what your changelog entry will look like:

馃悰 Bug Fixes

@florianduros florianduros added the T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems label Jan 22, 2024
@florianduros florianduros added T-Task Refactoring, enabling or disabling functionality, other engineering tasks and removed T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems labels Jan 22, 2024
@florianduros florianduros changed the title Make timeline a proxy Make timeline a getter Jan 22, 2024
@florianduros florianduros marked this pull request as ready for review January 22, 2024 15:49
@florianduros florianduros requested a review from a team as a code owner January 22, 2024 15:49
Copy link
Contributor

@andybalaam andybalaam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but definitely needs testing before merging.

@florianduros florianduros added T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems and removed T-Task Refactoring, enabling or disabling functionality, other engineering tasks labels Jan 26, 2024
@florianduros florianduros added this pull request to the merge queue Jan 26, 2024
Merged via the queue into develop with commit 2d1308c Jan 26, 2024
43 checks passed
@florianduros florianduros deleted the florianduros/unread/timeline-proxy branch January 26, 2024 14:05
@ThisIsMissEm
Copy link

This fixes my bug with Threads being marked permanently as unread, despite being read (they'd revert to unread after restart). Now I can actually mark all the threads as read (if I don't care about them)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
T-Defect Bugs, crashes, hangs, vulnerabilities, or other reported problems
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Huge amounts of log spam around hasUserReadEvent event ID X not found in room Y: this shouldn't happen!
3 participants