Validate backup private key before migrating it #4114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
…s://github.com/matrix-org/matrix-js-sdk into valere/element-r/migrate_local_trust_if_needed
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
Co-authored-by: Richard van der Hoff <1389908+richvdh@users.noreply.github.com>
BillCarsonFr
added
the
T-Task
BillCarsonFr
force-pushed
the
valere/element-r/validate_backup_key_before_migrating
branch
from
8cb1334
to
bf3e6d6
Compare
Base automatically changed from
valere/element-r/migrate_local_trust_if_needed
to
develop
March 18, 2024 09:21
BillCarsonFr
force-pushed
the
valere/element-r/validate_backup_key_before_migrating
branch
from
cda5200
to
6852682
Compare
BillCarsonFr
added
T-Defect
andybalaam
approved these changes
Apr 12, 2024
richvdh
reviewed
Apr 12, 2024
spec/test-utils/test_indexeddb_cryptostore_dump/no_cached_msk_dump/index.ts
Show resolved
Hide resolved
spec/test-utils/test_indexeddb_cryptostore_dump/no_cached_msk_dump/index.ts
Show resolved
Hide resolved
spec/test-utils/test_indexeddb_cryptostore_dump/no_cached_msk_dump/index.ts
Show resolved
Hide resolved
BillCarsonFr
deleted the
valere/element-r/validate_backup_key_before_migrating
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes element-hq/element-web#27324
Add some checks to validate that the legacy cached private key matches the current backup when migrating (it could have changed while the session was closed).
At the moment we need to have libolm available to check the key validity, it's was needed before that. Maybe see if we could expose some rust API?
Checklist
public/exportedsymbols have accurate TSDoc documentation.