-
-
Notifications
You must be signed in to change notification settings - Fork 578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add some test utils in a new entrypoint #4127
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
f489836
to
71c32e2
Compare
This just removes some of the most egregious lies and outdated stuff. There's a *lot* more that can be done here.
5639502
to
501a0f5
Compare
t3chguy
requested changes
Mar 22, 2024
src/testing.ts
Outdated
Comment on lines
134
to
138
* Create a `MatrixEvent` representing a successfully-decrypted `m.room.encrypted` event. | ||
* | ||
* @param opts - Values for the event. | ||
*/ | ||
export async function mkDecryptionFailureMatrixEvent(opts: { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The comment does not match the name success!=failure :D
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
oops
richvdh
commented
Mar 22, 2024
t3chguy
approved these changes
Mar 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We'd like a way to generate mock encrypted events in a way that doesn't require access to private classes/methods within the JS-SDK. Accordingly, here's a new entrypoint.
I couldn't bring myself to add stuff to the README without clearing out a little of the crap, so that's included here too.