Improve types for IPowerLevelsContent and hasSufficientPowerLevelFor
#4128
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Z-Community-PR
t3chguy
reviewed
Mar 22, 2024
t3chguy
added
the
T-Defect
galash13
force-pushed
the
powerlevel-check-actions
branch
from
9f58a97
to
c1a7c48
Compare
t3chguy
reviewed
Mar 25, 2024
galash13
force-pushed
the
powerlevel-check-actions
branch
from
c1a7c48
to
43fc0cb
Compare
richvdh
changed the title
IPowerLevelsContent and hasSufficientPowerLevelFor
t3chguy
reviewed
Mar 25, 2024
galash13
force-pushed
the
powerlevel-check-actions
branch
from
43fc0cb
to
76a4bcf
Compare
|
The only bit missing now is the sign off https://github.com/element-hq/element-web/blob/develop/CONTRIBUTING.md#sign-off |
Signed-off-by: Gabriele Messina <56839513+galash13@users.noreply.github.com>
galash13
force-pushed
the
powerlevel-check-actions
branch
from
76a4bcf
to
350a62e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while developing to use the hasSufficientPowerLevelFor method i logged the contents of a EventType.RoomPowerLevels state event for a room and found there were missing properties, which i add in this PR