Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add comment to make clear that RoomStateEvent.Events does not update related objects in the js-sdk #4152

Merged
merged 1 commit into from
Apr 17, 2024

Conversation

toger5
Copy link
Contributor

@toger5 toger5 commented Apr 8, 2024

Signed-off-by: Timo K toger5@hotmail.de

Checklist

  • Tests written for new code (and old code if feasible).
  • New or updated public/exported symbols have accurate TSDoc documentation.
  • Linter and other CI checks pass.
  • Sign-off given on the changes (see CONTRIBUTING.md).

…related objects in the js-sdk

Signed-off-by: Timo K <toger5@hotmail.de>
@toger5
Copy link
Contributor Author

toger5 commented Apr 8, 2024

We use canInvite in a couple of places but changing the power levels did not trigger anything so the related buttons were still greyed out.
I was trying to use useEventEmitterState with RoomStateEvent.Events but noticed, that the objects requested by canInvite were not updated yet when the event got emitted. This comment should help mitigate this pitfall.

@toger5 toger5 added T-Other Questions, user support, anything else T-Enhancement and removed T-Other Questions, user support, anything else labels Apr 8, 2024
@MidhunSureshR MidhunSureshR added this pull request to the merge queue Apr 17, 2024
Merged via the queue into develop with commit 4fc6ba8 Apr 17, 2024
39 of 42 checks passed
@MidhunSureshR MidhunSureshR deleted the toger5/comment-on-events-event branch April 17, 2024 10:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants